guowangy commented on code in PR #11722:
URL: https://github.com/apache/gluten/pull/11722#discussion_r2915560966
##########
cpp/core/shuffle/LocalPartitionWriter.cc:
##########
@@ -750,6 +869,9 @@ arrow::Status LocalPartitionWriter::hashEvict(
for (auto& payload : merged) {
RETURN_NOT_OK(payloadCache_->cache(partitionId, std::move(payload)));
}
+ if (usePartitionMultipleSegments_) {
+ RETURN_NOT_OK(flushCachedPayloads());
Review Comment:
Yes, `evictType == kSpill` is properly handled.
Because when `usePartitionMultipleSegments_` enabled, the cache mechanism of
`payloadCache_` is not used. Payloads will directly flush into disk; thus, we
don't need to distinguish between `kCache` and `kSpill`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
