zhouyuan commented on code in PR #11720:
URL: https://github.com/apache/gluten/pull/11720#discussion_r2930350509


##########
gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala:
##########
@@ -220,6 +220,28 @@ object Validators {
 
   private class FallbackByTimestampNTZ() extends Validator {
     override def validate(plan: SparkPlan): Validator.OutCome = {
+      // Check if TimestampNTZ validation is enabled via VeloxConfig
+      // Use reflection to avoid compile-time dependency on backends-velox 
module
+      val enableValidation =
+        try {
+          // scalastyle:off classforname
+          val veloxConfigClass = 
Class.forName("org.apache.gluten.config.VeloxConfig")

Review Comment:
   here's one example to get the gluten config:
   
https://github.com/apache/gluten/blob/main/gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala#L156



##########
job-logs.txt:
##########
@@ -0,0 +1,1930 @@
+2026-03-12T12:30:32.5688980Z Current runner version: '2.332.0'

Review Comment:
   remove this log?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to