philo-he commented on code in PR #12056:
URL: https://github.com/apache/gluten/pull/12056#discussion_r3243071946
##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetIOSuite.scala:
##########
@@ -17,14 +17,51 @@
package org.apache.spark.sql.execution.datasources.parquet
import org.apache.spark.sql._
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.types.{IntegerType, StringType, StructType}
/** A test suite that tests basic Parquet I/O. */
class GlutenParquetIOSuite extends ParquetIOSuite with GlutenSQLTestsBaseTrait
{
+ override def testNameBlackList: Seq[String] =
Review Comment:
`testGluten("SPARK-54220: xxx` will add a prefix into the test name. I
assume `excludeByPrefix("SPARK-54220")` will not exclude this test variant.
##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetIOSuite.scala:
##########
@@ -17,14 +17,51 @@
package org.apache.spark.sql.execution.datasources.parquet
import org.apache.spark.sql._
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.types.{IntegerType, StringType, StructType}
/** A test suite that tests basic Parquet I/O. */
class GlutenParquetIOSuite extends ParquetIOSuite with GlutenSQLTestsBaseTrait
{
+ override def testNameBlackList: Seq[String] =
Review Comment:
Can we keep this test excluded in VeloxTestSettings.scala? That way, it
won't affect other backends' test enabling controls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
