wecharyu commented on code in PR #12056:
URL: https://github.com/apache/gluten/pull/12056#discussion_r3252527294
##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetIOSuite.scala:
##########
@@ -17,14 +17,51 @@
package org.apache.spark.sql.execution.datasources.parquet
import org.apache.spark.sql._
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.types.{IntegerType, StringType, StructType}
/** A test suite that tests basic Parquet I/O. */
class GlutenParquetIOSuite extends ParquetIOSuite with GlutenSQLTestsBaseTrait
{
+ override def testNameBlackList: Seq[String] =
Review Comment:
I'd prefer exclude it here because this test failure is not Velox-specific,
it's caused by Gluten instead of backends.
Spark test collect leaf scan node `FileSourceScanExecTransformer` and run
`executeColumnar()` in `VerifyNoAdditionalScanOutputExec`:
https://github.com/apache/gluten/blob/356fda012d859f693fc613e6ac3585b7661bdbc5/shims/spark41/src/main/scala/org/apache/spark/sql/execution/AbstractFileSourceScanExec.scala#L139-L142
The inputRDD is `RDD[UnsafeRow]` for `parquetVectorizedReaderEnabled=false`
test path, so it would always failed by:
```bash
java.lang.ClassCastException: class
org.apache.spark.sql.catalyst.expressions.UnsafeRow cannot be cast to class
org.apache.spark.sql.vectorized.ColumnarBatch
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
