brijrajk commented on PR #12158:
URL: https://github.com/apache/gluten/pull/12158#issuecomment-4601318322
Removed the explicit `sparkConf` override that was setting
`spark.sql.ansi.enabled=false` in both `MathFunctionsValidateSuite` and
`ScalarFunctionsValidateSuite`.
Based on feedback from @philo-he on PR #12199, it turns out
`SPARK_ANSI_SQL_MODE` is already read directly by Spark in `SQLConf` to set the
default value:
```scala
.createWithDefault(!sys.env.get("SPARK_ANSI_SQL_MODE").contains("false"))
```
Since CI already sets `SPARK_ANSI_SQL_MODE=false` in
`velox_backend_x86.yml`, the explicit override is redundant. No code-level
override is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
