philo-he commented on PR #12158: URL: https://github.com/apache/gluten/pull/12158#issuecomment-4910072867
Hi @brijrajk, apologies for missing the earlier ping. This PR looks good overall. One thing I'd like to confirm: for some tests in `ScalarFunctionsValidateSuite.scala`, this PR removes the operator check, which seems to contradict the validate suite's design of ensuring an operator is offloaded (or not offloaded) as expected. So I'm wondering whether we should move those tests to another suite or simply remove them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
