liujiayi771 commented on code in PR #12264:
URL: https://github.com/apache/gluten/pull/12264#discussion_r3385060590
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -888,19 +888,6 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi with
Logging {
}
}
- override def doCanonicalizeForBroadcastMode(mode: BroadcastMode):
BroadcastMode = {
Review Comment:
This code is actually useful — when buildHashTableOncePerExecutor is
disabled, it provides more opportunities to reuse broadcast exchanges.
Moreover, I now think that even when buildHashTableOncePerExecutor is enabled,
the comment in doCanonicalizeForBroadcastMode still holds true: we still
broadcast byte arrays and build HashRelation at the executor side.
@JkSelf Can you explain why this was removed? This allows us to reuse
broadcast exchanges for different build keys with the same data.
We should either restore the code before
ColumnarBroadcastExchangeExec.doCanonicalize, or at least follow the original
logic when buildHashTableOncePerExecutor is disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
