JkSelf commented on PR #12264: URL: https://github.com/apache/gluten/pull/12264#issuecomment-4667462135
@wecharyu Thanks for your work. For ColumnarBroadcastExchangeExec, reuse is already decided by doCanonicalize(). It now directly uses [mode.canonicalized](https://github.com/apache/gluten/blob/9202345c23fec9e62f516bde51a07b09f4d58ef6/gluten-substrait/src/main/scala/org/apache/spark/sql/execution/ColumnarBroadcastExchangeExec.scala#L135), and that canonicalized BroadcastMode already captures the key BHJ semantics such as bound build keys and null-aware behavior. So we no longer need this handling for the unique broadcastId. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
