wecharyu commented on code in PR #12264:
URL: https://github.com/apache/gluten/pull/12264#discussion_r3421830074
##########
backends-velox/src/main/scala/org/apache/gluten/execution/VeloxBroadcastBuildSideCache.scala:
##########
@@ -30,7 +30,10 @@ import com.github.benmanes.caffeine.cache.{Cache, Caffeine,
RemovalCause, Remova
import java.util.concurrent.TimeUnit
-case class BroadcastHashTable(pointer: Long, relation: BuildSideRelation)
+case class BroadcastHashTable(
+ pointer: Long,
+ relation: BuildSideRelation,
+ droppedDuplicates: Boolean)
Review Comment:
Spark will convert ExistenceJoin to LeftSemiJoin, and null-aware anti join
will not be reused because the `HashedRelationBroadcastMode`'s `isNullAware` is
different, add a test to cover this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
