Copilot commented on code in PR #12308:
URL: https://github.com/apache/gluten/pull/12308#discussion_r3424495053
##########
backends-velox/src/test/scala/org/apache/gluten/functions/WindowFunctionsValidateSuite.scala:
##########
@@ -34,4 +34,23 @@ class WindowFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
+ test("lag/lead, nth_value window function with constant input") {
+ runQueryAndCompare(
+ "select lag(10, -2) over" +
+ " (partition by l_suppkey order by l_orderkey) from lineitem") {
+ checkGlutenPlan[WindowExecTransformer]
+ }
+
+ runQueryAndCompare(
+ "select lead(10, -2) over" +
Review Comment:
Same as the lag case above: this “constant input” test currently re-tests
the negative offset path. Switching to a positive offset makes the intent
clearer and reduces redundancy.
##########
backends-velox/src/test/scala/org/apache/gluten/functions/WindowFunctionsValidateSuite.scala:
##########
@@ -34,4 +34,23 @@ class WindowFunctionsValidateSuite extends
FunctionsValidateSuite {
}
}
+ test("lag/lead, nth_value window function with constant input") {
+ runQueryAndCompare(
+ "select lag(10, -2) over" +
Review Comment:
This test is intended to validate constant *input* support, but it reuses
the negative offset (-2) scenario already covered by the previous test. Using a
positive offset here keeps the test focused and avoids coupling it to the
separate “negative offset” behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
