Copilot commented on code in PR #12308:
URL: https://github.com/apache/gluten/pull/12308#discussion_r3424824629
##########
backends-velox/src/test/scala/org/apache/gluten/execution/MiscOperatorSuite.scala:
##########
@@ -514,7 +514,7 @@ class MiscOperatorSuite extends
VeloxWholeStageTransformerSuite with AdaptiveSpa
runQueryAndCompare(
"select l_suppkey, l_orderkey, nth_value(1, 2) over" +
" (partition by l_suppkey order by l_orderkey) from lineitem ") {
- checkSparkPlan[WindowExec]
+ checkSparkPlan[WindowExecTransformer]
Review Comment:
The comment above this assertion is now inaccurate: this test expects
`nth_value` with a foldable (constant) input to be offloaded to
`WindowExecTransformer`, so it is supported rather than unsupported. Please
update/remove the stale comment to avoid confusion when diagnosing window
offload behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
