rdtr commented on code in PR #12151:
URL: https://github.com/apache/gluten/pull/12151#discussion_r3445324741
##########
gluten-ut/spark40/src/test/scala/org/apache/spark/sql/GlutenBloomFilterAggregateQuerySuite.scala:
##########
@@ -112,6 +122,109 @@ class GlutenBloomFilterAggregateQuerySuite
}
}
+ // Regression test for https://github.com/apache/gluten/issues/12013
+ // When ExpandFallbackPolicy triggers a whole-stage AQE fallback, the
resulting plan comes
+ // from the original vanilla Spark plan which contains
BloomFilterMightContain (not the Velox
+ // variant). If Stage 0 (bloom_filter_agg subquery) already ran natively it
produced Velox-
+ // format bytes, which BloomFilterImpl.readFrom() cannot deserialize.
BloomFilterMightContain-
+ // FallbackPatcher patches the fallback plan to use
VeloxBloomFilterMightContain so Stage 1
Review Comment:
I think Patcher is now gone so this comment is outdated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
