brijrajk commented on code in PR #12151:
URL: https://github.com/apache/gluten/pull/12151#discussion_r3450318099
##########
gluten-ut/spark40/src/test/scala/org/apache/spark/sql/GlutenBloomFilterAggregateQuerySuite.scala:
##########
@@ -112,6 +122,109 @@ class GlutenBloomFilterAggregateQuerySuite
}
}
+ // Regression test for https://github.com/apache/gluten/issues/12013
+ // When ExpandFallbackPolicy triggers a whole-stage AQE fallback, the
resulting plan comes
+ // from the originalPlan snapshot captured before optimizer rules ran. Moving
+ // BloomFilterMightContainJointRewriteRule to injectOptimizerRule ensures
both the
+ // BloomFilterAggregate->VeloxBloomFilterAggregate and
BloomFilterMightContain->
+ // VeloxBloomFilterMightContain substitutions are baked into originalPlan,
so the byte
+ // format stays consistent regardless of which stages fall back.
+ testGluten(
+ "Test bloom_filter_agg whole-stage fallback does not corrupt bloom filter
bytes",
Review Comment:
Done — both tests are now named `"GLUTEN-12013: ..."`.
##########
gluten-ut/spark40/src/test/scala/org/apache/spark/sql/GlutenBloomFilterAggregateQuerySuite.scala:
##########
@@ -112,6 +122,109 @@ class GlutenBloomFilterAggregateQuerySuite
}
}
+ // Regression test for https://github.com/apache/gluten/issues/12013
+ // When ExpandFallbackPolicy triggers a whole-stage AQE fallback, the
resulting plan comes
+ // from the originalPlan snapshot captured before optimizer rules ran. Moving
+ // BloomFilterMightContainJointRewriteRule to injectOptimizerRule ensures
both the
+ // BloomFilterAggregate->VeloxBloomFilterAggregate and
BloomFilterMightContain->
+ // VeloxBloomFilterMightContain substitutions are baked into originalPlan,
so the byte
+ // format stays consistent regardless of which stages fall back.
+ testGluten(
+ "Test bloom_filter_agg whole-stage fallback does not corrupt bloom filter
bytes",
Review Comment:
Done — moved both regression tests into a new
`GlutenBloomFilterFallbackSuite` in `gluten-ut/test`, guarded with
`testWithMinSparkVersion("3.3")` (since `bloom_filter_agg` was introduced in
Spark 3.3). The `spark40` suite now only retains the four original imported
Spark tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
