Copilot commented on code in PR #12335:
URL: https://github.com/apache/gluten/pull/12335#discussion_r3485534399
##########
backends-velox/src/main/scala/org/apache/spark/sql/execution/utils/ExecUtil.scala:
##########
@@ -172,6 +173,9 @@ object ExecUtil {
// range partitioning fall back to row-based partition id computation
case RangePartitioning(orders, n) =>
new NativePartitioning(GlutenShuffleUtils.RangePartitioningShortName,
n)
+ case other =>
+ throw new GlutenNotSupportException(
+ s"Partitioning ${other.getClass.getSimpleName} is not supported by
native shuffle")
Review Comment:
The new defensive `case other =>` improves on `MatchError`, but the
exception message now only includes `other.getClass.getSimpleName`, which loses
the very useful details Spark puts in `Partitioning.toString` (expressions,
numPartitions, etc.). Including `$other` directly will make future debugging
much easier while still avoiding `MatchError`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
