brijrajk commented on PR #12335: URL: https://github.com/apache/gluten/pull/12335#issuecomment-4817881913
@liuneng1994 thanks for the review. Both comments are addressed in the latest push: - **Tests**: added a dedicated `GlutenKeyGroupedPartitioningSuite` test (spark40 and spark41) that asserts the `KeyGroupedPartitioning` shuffle falls back to a vanilla `ShuffleExchangeExec` and is never offloaded to `ColumnarShuffleExchangeExec`, then checks the join result. This complements the existing `SPARK-41471` one-side tests by verifying the fallback path specifically rather than just the shuffle count. - **Error message** (Copilot suggestion): the `GlutenNotSupportException` in `ExecUtil.genShuffleDependency` now embeds the full partitioning `toString` (expressions, numPartitions) instead of only the class name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
