felipepessoto commented on code in PR #12388:
URL: https://github.com/apache/gluten/pull/12388#discussion_r3502475814
##########
.github/workflows/velox_backend_x86.yml:
##########
@@ -93,6 +102,24 @@ jobs:
name: velox-native-lib-centos-7-${{github.sha}}
path: ./cpp/build/
if-no-files-found: error
+ # Consumed by the reusable Delta workflow (delta-spark-ut job).
+ - uses: actions/upload-artifact@v4
+ with:
+ name: velox-arrow-jars-centos-7-${{github.sha}}
+ path: .m2/repository/org/apache/arrow/
+ if-no-files-found: error
+
+ # Delta Spark UT, run via the reusable workflow so it reuses the native lib +
+ # arrow jars built above instead of duplicating the native build. Not gated
on
+ # Delta-only paths: core/velox/substrait/cpp/shims changes can affect Delta
+ # query offload, so this runs on every trigger like the other spark-test
jobs.
+ delta-spark-ut:
+ needs: build-native-lib-centos-7
+ uses: ./.github/workflows/delta_spark_ut.yml
+ with:
+ native_lib_artifact: velox-native-lib-centos-7-${{ github.sha }}
+ arrow_jars_artifact: velox-arrow-jars-centos-7-${{ github.sha }}
+ secrets: inherit
Review Comment:
Done in 6fe545120. Removed secrets: inherit from the reusable Delta UT
call. delta_spark_ut.yml declares no secrets: and references no ${{
secrets.* }} , and artifact download/cache use the automatic GITHUB_TOKEN
(provided to reusable workflows without inherit ), so dropping it is safe and
reduces blast radius.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
