kevinwilfong opened a new pull request, #12421: URL: https://github.com/apache/gluten/pull/12421
## What changes are proposed in this pull request? Clang 21 introduced a new warning -Wcharacter-conversion https://releases.llvm.org/21.1.0/tools/clang/docs/ReleaseNotes.html#improvements-to-clang-s-diagnostics It's triggered when implicitly converting between char8_t, char16_t, char32_t. This is causing `./dev/builddeps-veloxbe.sh build_arrow` to fail, as it builds gtest as a dependency and it has an implicit conversion in one of its headers. ``` FAILED: [code=1] _deps/googletest-build/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o /Users/kevinwilfong/incubator-gluten/ep/build-velox/build/velox_ep/deps-install/bin/ccache /Library/Developer/CommandLineTools/usr/bin/c++ -DARROW_WITH_TIMING_TESTS -DGTEST_CREATE_SHARED_LIBRARY=1 -Dgtest_EXPORTS -I/Users/kevinwilfong/incubator-gluten/ep/_ep/arrow_ep/cpp/_build/_deps/googletest-src/googletest/include -fPIC -Wall -Wshadow -Werror -Wconversion -DGTEST_HAS_PTHREAD=1 -fexceptions -W -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wredundant-decls -MD -MT _deps/googletest-build/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o -MF _deps/googletest-build/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o.d -o _deps/googletest-build/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o -c /Users/kevinwilfong/incubator-gluten/ep/_ep/arrow_ep/cpp/_build/_deps/googletest-src/googletest/src/gtest-all.cc In file included from /Users/kevinwilfong/incubator-gluten/ep/_ep/arrow_ep/cpp/_build/_deps/googletest-src/googletest/src/gtest-all.cc:38: In file included from /Users/kevinwilfong/incubator-gluten/ep/_ep/arrow_ep/cpp/_build/_deps/googletest-src/googletest/include/gtest/gtest.h:64: In file included from /Users/kevinwilfong/incubator-gluten/ep/_ep/arrow_ep/cpp/_build/_deps/googletest-src/googletest/include/gtest/gtest-death-test.h:41: In file included from /Users/kevinwilfong/incubator-gluten/ep/_ep/arrow_ep/cpp/_build/_deps/googletest-src/googletest/include/gtest/internal/gtest-death-test-internal.h:39: In file included from /Users/kevinwilfong/incubator-gluten/ep/_ep/arrow_ep/cpp/_build/_deps/googletest-src/googletest/include/gtest/gtest-matchers.h:44: /Users/kevinwilfong/incubator-gluten/ep/_ep/arrow_ep/cpp/_build/_deps/googletest-src/googletest/include/gtest/gtest-printers.h:478:35: error: implicit conversion from 'char8_t' to 'char32_t' may change the meaning of the represented code unit [-Werror,-Wcharacter-conversion] 478 | PrintTo(ImplicitCast_<char32_t>(c), os); | ~~~~~~~~~~~~~ ^ 1 error generated. ``` This PR proposes not treating those warnings as errors when building Arrow. ## How was this patch tested? Built Arrow successfully using Apple Clang 21. ## Was this patch authored or co-authored using generative AI tooling? co-authored with Claude Opus 4.8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
