zml1206 commented on code in PR #12421:
URL: https://github.com/apache/gluten/pull/12421#discussion_r3509892491
##########
dev/build-arrow.sh:
##########
@@ -41,11 +41,18 @@ function build_arrow_cpp() {
ARROW_WITH_ZLIB=ON
# The zlib version bundled with arrow is not compatible with clang 17.
# It can be removed after upgrading the arrow version.
+ EXTRA_CMAKE_CXX_FLAGS=""
if [[ "$(uname)" == "Darwin" ]]; then
clang_major_version=$(echo | clang -dM -E - | grep __clang_major__ | awk
'{print $3}')
if [ "${clang_major_version}" -ge 17 ]; then
ARROW_WITH_ZLIB=OFF
fi
+ # Apple clang 21+ promotes implicit char8_t -> char32_t conversions in
+ # Arrow's bundled googletest to errors under -Werror. Downgrade just that
+ # diagnostic. Can be removed once an Arrow upgrade ships a newer
googletest.
+ if [ "${clang_major_version}" -ge 21 ]; then
+ EXTRA_CMAKE_CXX_FLAGS="-Wno-error=character-conversion"
+ fi
Review Comment:
Since -Wcharacter-conversion is introduced by Clang 21 generally, should we
gate this by Clang major version instead of Darwin only? Linux builds using
clang-21 may hit the same Arrow bundled googletest failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
