kevinwilfong opened a new pull request, #12423: URL: https://github.com/apache/gluten/pull/12423
## What changes are proposed in this pull request? https://github.com/apache/gluten/pull/12105 introduced the flag -DCMAKE_NO_SYSTEM_FROM_IMPORTED=ON to Velox builds. This has the unintended side effect of including dependencies' header files as non-system includes which means that warnings in the build are promoted to errors, e.g. ``` In file included from t.cc:1: In file included from …/deps-install/include/re2/re2.h:220: In file included from …/deps-install/include/absl/base/call_once.h:40: In file included from …/deps-install/include/absl/base/nullability.h:153: In file included from …/deps-install/include/absl/base/internal/nullability_impl.h:22: …/deps-install/include/absl/meta/type_traits.h:511:36: error: builtin __is_trivially_relocatable is deprecated; use __builtin_is_cpp_trivially_relocatable instead [-Werror,-Wdeprecated-builtins] 511 | : std::integral_constant<bool, __is_trivially_relocatable(T)> {}; | ^ 1 error generated. ``` To fix this, this PR proposes explicitly including the header files under ${INSTALL_PREFIX}/include from dependencies as system includes, suppressing these errors which we have limited control over. ## How was this patch tested? Executed ./dev/builddeps-veloxbe.sh on a Mac with Clang 21, verified we no longer got errors from warnings in dependencies. Combined with my other recent changes https://github.com/apache/gluten/pull/12421 https://github.com/apache/gluten/pull/12422 I was able to successfully run ./dev/builddeps-veloxbe.sh on an otherwise fresh checkout. ## Was this patch authored or co-authored using generative AI tooling? Co-authored with Claude Opus 4.8 Generated-by: Claude Opus 4.8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
