kevinwilfong opened a new pull request, #12422:
URL: https://github.com/apache/gluten/pull/12422
## What changes are proposed in this pull request?
At least on Mac, Velox installs its dependencies in a directory local to the
checkout, with Gluten this is typically
incubator-gluten/ep/build-velox/build/velox_ep/deps-install. One of these
dependencies is fbthrift.
Currently the CMakeLists.txt file in cpp/velox is hard coded to look for
Thrift in /usr/local/lib, which is inconsistent and results in an error
building Gluten.
```
CMake Error at velox/CMakeLists.txt:431 (message):
Could not find thrift libraries. Please install them or use vcpkg.
```
The fix is to update the CMakeLists.txt file to look for Thrift in the
directory Velox installs its dependencies ${CMAKE_PREFIX_PATH} and if it can't
find it there fall back to /usr/local/lib to preserve the existing behavior.
## How was this patch tested?
Ran `./dev/builddeps-veloxbe.sh build_gluten_cpp` on a Mac without Thrift
installed in /usr/local/lib and verified it could find Thrift in the directory
Velox installed the dependencies.
## Was this patch authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
