Copilot commented on code in PR #12242:
URL: https://github.com/apache/gluten/pull/12242#discussion_r3534156694
##########
gluten-ut/spark40/src/test/scala/org/apache/spark/sql/GlutenBitmapExpressionsQuerySuite.scala:
##########
@@ -37,4 +38,23 @@ class GlutenBitmapExpressionsQuerySuite
"Expected native HashAggregateExecBaseTransformer in plan"
)
}
+
+ test("bitmap_or_agg routes to native") {
Review Comment:
This test will start running in Velox UTs (the suite is enabled in
VeloxTestSettings) but the PR description notes the native Velox
`bitmap_or_agg` implementation is still pending upstream. Until the Velox
function is available and Gluten’s Velox dependency is updated, this assertion
will fail (fallback plan won’t contain a native BitmapOrAgg aggregate).
Consider temporarily disabling the test (or excluding it via VeloxTestSettings)
until the upstream function lands.
##########
gluten-ut/spark35/src/test/scala/org/apache/spark/sql/GlutenBitmapExpressionsQuerySuite.scala:
##########
@@ -37,4 +38,23 @@ class GlutenBitmapExpressionsQuerySuite
"Expected native HashAggregateExecBaseTransformer in plan"
)
}
+
+ test("bitmap_or_agg routes to native") {
Review Comment:
This test will start running in Velox UTs (the suite is enabled in
VeloxTestSettings) but the PR description notes the native Velox
`bitmap_or_agg` implementation is still pending upstream. Until the Velox
function is available and Gluten’s Velox dependency is updated, this assertion
will fail (fallback plan won’t contain a native BitmapOrAgg aggregate).
Consider temporarily disabling the test (or excluding it via VeloxTestSettings)
until the upstream function lands.
##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/GlutenBitmapExpressionsQuerySuite.scala:
##########
@@ -37,4 +38,23 @@ class GlutenBitmapExpressionsQuerySuite
"Expected native HashAggregateExecBaseTransformer in plan"
)
}
+
+ test("bitmap_or_agg routes to native") {
Review Comment:
This test will start running in Velox UTs (the suite is enabled in
VeloxTestSettings) but the PR description notes the native Velox
`bitmap_or_agg` implementation is still pending upstream. Until the Velox
function is available and Gluten’s Velox dependency is updated, this assertion
will fail (fallback plan won’t contain a native BitmapOrAgg aggregate).
Consider temporarily disabling the test (or excluding it via VeloxTestSettings)
until the upstream function lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
