minni31 commented on code in PR #12242:
URL: https://github.com/apache/gluten/pull/12242#discussion_r3534387082


##########
gluten-ut/spark35/src/test/scala/org/apache/spark/sql/GlutenBitmapExpressionsQuerySuite.scala:
##########
@@ -37,4 +38,23 @@ class GlutenBitmapExpressionsQuerySuite
       "Expected native HashAggregateExecBaseTransformer in plan"
     )
   }
+
+  test("bitmap_or_agg routes to native") {

Review Comment:
   PR description has been updated and we do have Velox upstream changes added. 
So it should work fine.



##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/GlutenBitmapExpressionsQuerySuite.scala:
##########
@@ -37,4 +38,23 @@ class GlutenBitmapExpressionsQuerySuite
       "Expected native HashAggregateExecBaseTransformer in plan"
     )
   }
+
+  test("bitmap_or_agg routes to native") {

Review Comment:
   PR description has been updated and we do have Velox upstream changes added. 
So it should work fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to