Copilot commented on code in PR #12453:
URL: https://github.com/apache/gluten/pull/12453#discussion_r3542232195
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -233,7 +233,7 @@ object VeloxBackendSettings extends BackendSettingsApi {
}
def validateDataSchema(): Option[String] = {
- if (VeloxConfig.get.parquetUseColumnNames &&
VeloxConfig.get.orcUseColumnNames) {
+ if (VeloxConfig.get.parquetUseColumnNames) {
return None
}
Review Comment:
`validateDataSchema()` now returns early solely based on
`parquetUseColumnNames`. But after this PR, ORC/DWRF always attaches the table
schema to the native reader (see
`VeloxIteratorApi.setFileSchemaForLocalFiles`), so schema-type validation
should still run for ORC/DWRF even when `parquetUseColumnNames=true`. Otherwise
unsupported data types in ORC/DWRF table schema may slip through validation and
fail at runtime instead of cleanly falling back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
