Copilot commented on code in PR #12453:
URL: https://github.com/apache/gluten/pull/12453#discussion_r3542813586
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -233,7 +233,7 @@ object VeloxBackendSettings extends BackendSettingsApi {
}
def validateDataSchema(): Option[String] = {
- if (VeloxConfig.get.parquetUseColumnNames &&
VeloxConfig.get.orcUseColumnNames) {
+ if (VeloxConfig.get.parquetUseColumnNames) {
return None
}
Review Comment:
`validateDataSchema` now short-circuits solely on `parquetUseColumnNames`,
but ORC/DWRF scans always attach the table schema to `LocalFilesNode` (and may
do positional mapping per-file). This means unsupported types in the
requested/table schema for ORC/DWRF can slip past validation and fail later in
native. Consider validating the table schema for ORC/DWRF unconditionally, and
for Parquet only when `parquetUseColumnNames` is false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
