Copilot commented on code in PR #12400:
URL: https://github.com/apache/gluten/pull/12400#discussion_r3549515445
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -176,9 +176,9 @@ object VeloxConfig extends ConfigRegistry {
val COLUMNAR_VELOX_SSD_CACHE_IO_THREADS =
buildStaticConf("spark.gluten.sql.columnar.backend.velox.ssdCacheIOThreads")
- .doc("The IO threads for cache promoting")
+ .doc("The number of IO threads for SSD cache read/write operations")
.intConf
- .createWithDefault(1)
+ .createWithDefault(4)
Review Comment:
`ssdCacheIOThreads` is used natively to construct a
`folly::IOThreadPoolExecutor` (see `cpp/velox/compute/VeloxBackend.cc`), but
this Spark config currently has no value validation. If a user sets it to
0/negative, it can lead to runtime failures when initializing the SSD cache
thread pool. Add a positive-value check (consistent with other thread-count
configs like `spark.gluten.velox.s3UploadThreads`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
