Copilot commented on code in PR #12327:
URL: https://github.com/apache/gluten/pull/12327#discussion_r3557663046
##########
gluten-flink/ut/src/test/java/org/apache/gluten/table/runtime/stream/custom/NexmarkTest.java:
##########
@@ -242,11 +267,48 @@ private void executeQuery(StreamTableEnvironment tEnv,
String queryFileName, boo
assertThat(checkJobRunningStatus(insertResult, 30000) == true);
} else {
waitForJobCompletion(insertResult, 30000);
+ // Allow filesystem sink to flush and commit partitions after job
completion.
+ Thread.sleep(2000);
+ if ("q10_orc.sql".equals(queryFileName)) {
+ verifyQ10OrcOutput(queryStartMillis);
+ }
Review Comment:
`executeQuery(...)` sleeps 2 seconds after *every* bounded query completion.
Since `testAllNexmarkSourceQueries()` runs all Nexmark SQL files, this adds ~2s
per query and can significantly slow the UT suite even when the query isn't a
filesystem sink.
Consider scoping the sleep (and any post-completion delay) to `q10_orc.sql`
only, since that's the only query with an output verification that depends on
filesystem partition commit timing.
##########
gluten-flink/pom.xml:
##########
@@ -31,6 +31,8 @@
<properties>
<flink.version>1.19.2</flink.version>
<velox4j.version>0.1.0-SNAPSHOT</velox4j.version>
+ <protobuf.version>3.25.5</protobuf.version>
+ <hadoop.version>2.7.2</hadoop.version>
Review Comment:
This module overrides parent-level properties named `protobuf.version` and
`hadoop.version`. Since these properties are also defined in the repository
root POM, redefining them here can silently change dependency versions for
*all* gluten-flink submodules (and can make the overall reactor build harder to
reason about).
Consider either (a) using module-specific property names (e.g.
`gluten.flink.protobuf.version`, `gluten.flink.hadoop.version`) and updating
the few references that need them, or (b) aligning to the root property values
and removing these overrides.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
