wangxinshuo-bolt commented on code in PR #12535:
URL: https://github.com/apache/gluten/pull/12535#discussion_r3594163280
##########
cpp/core/jni/JniWrapper.cc:
##########
@@ -273,6 +273,14 @@ class ShuffleStreamReader : public StreamReader {
} // namespace
+namespace gluten {
+
+std::shared_ptr<StreamReader> makeShuffleStreamReader(JNIEnv* env, jobject
jShuffleStreamReader) {
Review Comment:
> why do we need to wrap it.
`ShuffleStreamReader` is a private implementation within `JniWrapper.cc`; we
need a function to expose the mechanism for creating `ShuffleStreamReader`
instances for different backends.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
