zhztheplayer commented on code in PR #12535:
URL: https://github.com/apache/gluten/pull/12535#discussion_r3630212942
##########
cpp/core/compute/Runtime.h:
##########
@@ -190,6 +191,8 @@ class Runtime : public
std::enable_shared_from_this<Runtime> {
return dumper_.get();
}
+ virtual std::unique_ptr<ColumnarBatchIterator> createJniInputIterator(const
JniInputIteratorContext& context);
Review Comment:
`JniInputIteratorContext::env` is of type `JNIEnv*` which requires `jni.h`,
while the Runtime API is currently isolated from the JNI layer. Does it look
like a design issue in the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
