Copilot commented on code in PR #12546:
URL: https://github.com/apache/gluten/pull/12546#discussion_r3601095175
##########
gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -875,7 +873,9 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenDataFrameTableValuedFunctionsSuite]
enableSuite[GlutenDataFrameTransposeSuite]
enableSuite[GlutenDeprecatedDatasetAggregatorSuite]
- // TODO: 4.x enableSuite[GlutenExplainSuite] // 1 failure
+ disableSuite[GlutenExplainSuite](
+ "Validates Spark-specific physical plan and JVM codegen output that does
not apply to " +
+ "Gluten's native execution plan")
Review Comment:
Minor grammar: the subject here is plural ("physical plans" + codegen
output), so the relative clause should use "do not apply" (and optionally
pluralize "plan").
##########
gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -895,7 +893,9 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenDataFrameTransposeSuite]
enableSuite[GlutenDefaultANSIValueSuite]
enableSuite[GlutenDeprecatedDatasetAggregatorSuite]
- // TODO: 4.x enableSuite[GlutenExplainSuite] // 1 failure
+ disableSuite[GlutenExplainSuite](
+ "Validates Spark-specific physical plan and JVM codegen output that does
not apply to " +
+ "Gluten's native execution plan")
Review Comment:
Minor grammar: the subject here is plural ("physical plans" + codegen
output), so the relative clause should use "do not apply" (and optionally
pluralize "plan").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
