Copilot commented on code in PR #12546:
URL: https://github.com/apache/gluten/pull/12546#discussion_r3611818972
##########
gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -875,7 +873,9 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenDataFrameTableValuedFunctionsSuite]
enableSuite[GlutenDataFrameTransposeSuite]
enableSuite[GlutenDeprecatedDatasetAggregatorSuite]
- // TODO: 4.x enableSuite[GlutenExplainSuite] // 1 failure
+ disableSuite[GlutenExplainSuite](
+ "Validates Spark-specific physical plan and JVM codegen output that does
not apply to " +
+ "Gluten's native execution plan")
Review Comment:
PR description says the "valid variant binary" test is now enabled while
keeping only the invalid case excluded, but this Spark 4.1 VeloxTestSettings
still excludes both cases via `GlutenVariantSuite` (see `.exclude("SPARK-47546:
valid variant binary")`). Please either update the PR description to match
reality, or adjust the settings so only the invalid case remains excluded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
