LuciferYang opened a new pull request, #12550:
URL: https://github.com/apache/gluten/pull/12550

   ### What changes were proposed in this pull request?
   
   Follow-up to the Spark 3.2 code cleanup PRs (#12522, #12525, #12532, #12524, 
#12541, #12543, #12548). This picks up the remaining build-system, dev-script, 
and documentation leftovers that referred to the no-longer-supported Spark 3.2 
shim.
   
   **`package/pom.xml`**
   
   Drop the `<exclude>*spark3.2*</exclude>` entry from the `maven-clean-plugin` 
fileset. The pattern protected artifacts that are no longer produced. Sibling 
entries for the currently-supported versions (`spark3.3` through `spark4.1`) 
are kept.
   
   **`LICENSE`**
   
   - Drop 9 stale `./shims/spark32/...` paths from the Apache Spark attribution 
section — the `shims/spark32/` directory was removed when Spark 3.2 support was 
dropped. Sibling `./shims/spark33/...` paths kept.
   - Drop 6 stale `./backends-clickhouse/src-delta-20/...` paths from the Delta 
Lake attribution section — Delta 2.0 is the Spark-3.2-era Delta, and the 
directory was removed by #12524. Sibling `src-delta-23`/`src-delta-33` lines 
are left untouched.
   
   **`dev/run-scala-test.sh`, `dev/bloop-test.sh`**
   
   Remove the `spark32` / `gluten-ut-spark32` module-map entries in both 
scripts. Both mapped to `shims/spark32` and `gluten-ut/spark32` filesystem 
paths that no longer exist.
   
   **`ep/build-clickhouse/src/resources/bin/gluten.sh`**
   
   Drop the dead `if [ "$SPARK_MAJOR_MINOR_VERSION" == "3.2" ]; then 
GLUTEN_JARS=…/jars/spark32/*` branch. `SPARK_MAJOR_MINOR_VERSION` cannot be 
`3.2` on any supported build. The remaining `3.3` branch and the else-fail path 
are unchanged.
   
   **`docs/developers/NewToGluten.md`**
   
   Rewrite the TPC-H troubleshooting failure-message example from 
`/tmp/tpch-approved-plan/v2-bhj/spark322/5.txt` (fictional subType + Spark 
3.2.2) to a real path using a currently-supported version: 
`/tmp/tpch-approved-plan/v1-bhj/spark35/5.txt`. The `subType()` values are `v1` 
/ `v1-bhj` / `v1-ras` / `v1-bhj-ras`.
   
   No functional change on any supported Spark version.
   
   ### Out of scope (deferred)
   
   Broader `LICENSE` hygiene unrelated to Spark 3.2 (paths using 
`src-delta-23`/`src-delta-33` with hyphens while on-disk directories are 
`src-delta23`/`src-delta33`, plus a stale `SparkWriteFilesCommitProtocol.scala` 
path) is intentionally left to a separate PR.
   
   ### How was this patch tested?
   
   - `grep -rn 'spark3\.2|shims/spark32|src-delta-20'` against the touched 
files: 0 remaining occurrences.
   - `grep -rn 'spark32|spark3\.2'` repo-wide (excluding 
target/generated/verbatim Delta-fork files and CH Spark-error-test golden 
data): confirms the only remaining `spark32` mentions are inside upstream Delta 
test files and Spark's own SQL-error golden output (both DO NOT TOUCH).
   - No source (`.scala`, `.java`, `.cpp`) files touched → no compile step 
needed.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude claude-opus-4-7
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to