Copilot commented on code in PR #12550: URL: https://github.com/apache/gluten/pull/12550#discussion_r3602802558
########## docs/developers/NewToGluten.md: ########## @@ -428,7 +428,7 @@ The following failure may occur in GitHub CI or local tests: ```log - TPC-H q5 *** FAILED *** Mismatch for query 5 - Actual Plan path: /tmp/tpch-approved-plan/v2-bhj/spark322/5.txt - Golden Plan path: /opt/gluten/backends-velox/target/scala-2.12/test-classes/tpch-approved-plan/v2-bhj/spark322/5.txt (VeloxTPCHSuite.scala:101) + Actual Plan path: /tmp/tpch-approved-plan/v1-bhj/spark35/5.txt + Golden Plan path: /opt/gluten/backends-velox/target/scala-2.12/test-classes/tpch-approved-plan/v1-bhj/spark35/5.txt (VeloxTPCHSuite.scala:101) Review Comment: The example log still references `VeloxTPCHSuite.scala:101`, but in the current code the golden-file path construction is at a different line. Since line numbers are volatile, it would be less misleading to drop the specific line number (or update it to the current location). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
