philo-he commented on PR #12388: URL: https://github.com/apache/gluten/pull/12388#issuecomment-5026316287
> For the maintainers @philo-he @zhztheplayer : this runs on every velox_backend_x86 trigger. Fair reasoning, but with https://github.com/apache/gluten/issues/12288 going on it should be a deliberate choice — every PR, Delta paths only, or nightly + label. Any works for me. @felipepessoto, we should avoid unnecessary GHA resource consumption, since our usage is still running high. That sometimes means making tradeoffs, particularly for failure cases that are rare. With that in mind, I'd suggest scheduling a nightly job that runs the full test set against the latest main, and narrowing the per-PR Delta tests to the most relevant cases that guard the key functionality. The per-PR job could also be triggered only by changes to the Delta module and a few core-related modules, so PRs that don't touch those paths skip it entirely. This keeps fast, focused signal on every PR while still catching the rarer regressions once a day. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
