Copilot commented on code in PR #12388:
URL: https://github.com/apache/gluten/pull/12388#discussion_r3617784035
##########
.github/workflows/velox_backend_x86.yml:
##########
@@ -94,6 +99,70 @@ jobs:
path: ./cpp/build/
if-no-files-found: error
+ # Delta Spark UT, run via the reusable workflow so it reuses the native lib
+ # built above instead of duplicating the native build. Not gated on
Delta-only
+ # paths: core/velox/substrait/cpp/shims changes can affect Delta query
offload,
+ # so this runs on every trigger like the other spark-test jobs.
Review Comment:
The header comment here says the Delta Spark UT job “runs on every trigger”,
but the actual logic below intentionally gates the reusable workflow per-PR
(Delta-relevant paths or `run-delta-ci` label). This is a bit misleading for
future maintainers; updating the comment to match the gating behavior will
avoid confusion about when the Delta suite should run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
