Smallfu666 commented on code in PR #12602:
URL: https://github.com/apache/gluten/pull/12602#discussion_r3637034054
##########
.github/workflows/velox_backend_cache.yml:
##########
@@ -55,6 +55,12 @@ jobs:
with:
path: '${{ env.CCACHE_DIR }}'
key: ccache-centos7-release-default-${{github.sha}}
+ - name: Save Ccache to Apache Stash
+ uses:
apache/infrastructure-actions/stash/save@0ba14156c9f4c3cfbe4b0c9f36339ab0f8d81e53
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos7-release-default
+ include-hidden-files: true
Review Comment:
Yes. The pinned Stash save action defines `include-hidden-files` and
forwards it to `actions/upload-artifact`:
https://github.com/apache/infrastructure-actions/blob/0ba14156c9f4c3cfbe4b0c9f36339ab0f8d81e53/stash/save/action.yml#L75-L79.
It is needed here because the cache path itself is `.ccache`, so I kept it
enabled.
##########
.github/workflows/velox_backend_cache.yml:
##########
@@ -55,6 +55,12 @@ jobs:
with:
path: '${{ env.CCACHE_DIR }}'
key: ccache-centos7-release-default-${{github.sha}}
+ - name: Save Ccache to Apache Stash
+ uses:
apache/infrastructure-actions/stash/save@0ba14156c9f4c3cfbe4b0c9f36339ab0f8d81e53
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos7-release-default
Review Comment:
Done in `90779832d`. All five Stash producer keys now append `${{
hashFiles('ep/build-velox/src/**') }}`. I used the `/**` glob so `hashFiles`
matches the files inside that directory rather than potentially hashing no
files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
