Copilot commented on code in PR #12625:
URL: https://github.com/apache/gluten/pull/12625#discussion_r3649821371
##########
dev/docker/Dockerfile.centos9-static-build:
##########
@@ -33,15 +33,15 @@ RUN set -ex; \
git clone --depth=1 https://github.com/apache/gluten /opt/gluten; \
cd /opt/gluten && bash ./dev/vcpkg/setup-build-depends.sh; \
mkdir -p ${VCPKG_PATH}; \
- echo "Build arrow, then install the native libs to system paths and jar
package to .m2/ directory."; \
+ echo "vcpkg installs the native dependencies and Maven resolves Java
dependencies."; \
if [ "$(uname -m)" = "aarch64" ]; then \
export CPU_TARGET="aarch64"; \
export VCPKG_FORCE_SYSTEM_BINARIES=1; \
fi; \
source /opt/rh/gcc-toolset-12/enable; \
cd /opt/gluten; \
bash ./dev/builddeps-veloxbe.sh --enable_vcpkg=ON --build_tests=ON
--enable_s3=ON --enable_gcs=ON \
- --enable_hdfs=ON --enable_abfs=ON
build_arrow; \
+ --enable_hdfs=ON --enable_abfs=ON true; \
Review Comment:
Passing `true` as a positional argument to `dev/builddeps-veloxbe.sh` makes
the script run only the `true` command (it skips the default get/build flow
when any commands are provided), so Velox/Gluten native builds are skipped in
this Docker image. Drop the extra argument so the script executes its default
build flow under vcpkg mode.
##########
dev/docker/Dockerfile.centos8-gcc13-static-build:
##########
@@ -37,14 +37,14 @@ RUN set -ex; \
dnf clean all; \
git clone --depth=1 https://github.com/apache/gluten /opt/gluten; \
mkdir -p ${VCPKG_PATH}; \
- echo "Build arrow, then install the native libs to system paths and jar
package to .m2/ directory."; \
+ echo "vcpkg installs the native dependencies and Maven resolves Java
dependencies."; \
if [ "$(uname -m)" = "aarch64" ]; then \
export CPU_TARGET="aarch64"; \
export VCPKG_FORCE_SYSTEM_BINARIES=1; \
fi; \
cd /opt/gluten; \
bash ./dev/builddeps-veloxbe.sh --enable_vcpkg=ON --build_tests=ON
--enable_s3=ON --enable_gcs=ON \
- --enable_hdfs=ON --enable_abfs=ON
build_arrow; \
+ --enable_hdfs=ON --enable_abfs=ON true; \
Review Comment:
The trailing `true` becomes the only command executed by
`dev/builddeps-veloxbe.sh` (it skips the default build path when any commands
are provided), so this image won't actually build Velox/Gluten native
artifacts. Remove the `true` argument so the default build runs.
##########
dev/docker/Dockerfile.centos7-static-build:
##########
@@ -39,12 +39,12 @@ RUN set -ex; \
echo "check_certificate = off" >> ~/.wgetrc; \
cd /opt/gluten && bash ./dev/vcpkg/setup-build-depends.sh; \
mkdir -p ${VCPKG_PATH}; \
- echo "Build arrow, then install the native libs to system paths and jar
package to .m2/ directory."; \
+ echo "vcpkg installs the native dependencies and Maven resolves Java
dependencies."; \
cd /opt/gluten; \
source /opt/rh/devtoolset-11/enable; \
source /opt/rh/rh-git227/enable; \
bash ./dev/builddeps-veloxbe.sh --enable_vcpkg=ON --build_tests=ON
--enable_s3=ON --enable_gcs=ON \
- --enable_hdfs=ON --enable_abfs=ON
build_arrow; \
+ --enable_hdfs=ON --enable_abfs=ON
true; \
Review Comment:
`dev/builddeps-veloxbe.sh` executes its default build only when there are no
positional commands. With `true` supplied, it will run only `true` and skip
building Velox/Gluten. Remove the positional argument so the native build
actually runs.
##########
dev/docker/Dockerfile.centos7-gcc13-static-build:
##########
@@ -43,10 +43,10 @@ RUN set -ex; \
yum remove gcc -y && yum clean all; \
yes | cp -rf /usr/share/aclocal/* /usr/local/share/aclocal/; \
mkdir -p ${VCPKG_PATH}; \
- echo "Build arrow, then install the native libs to system paths and jar
package to .m2/ directory."; \
+ echo "vcpkg installs the native dependencies and Maven resolves Java
dependencies."; \
cd /opt/gluten; \
bash ./dev/builddeps-veloxbe.sh --enable_vcpkg=ON --build_tests=ON
--enable_s3=ON --enable_gcs=ON \
- --enable_hdfs=ON --enable_abfs=ON
build_arrow; \
+ --enable_hdfs=ON --enable_abfs=ON
true; \
Review Comment:
The trailing `true` is interpreted as an explicit command by
`dev/builddeps-veloxbe.sh`, preventing the script's default flow
(get_velox/setup/build). Remove it so the image actually builds the native
dependencies under vcpkg mode.
##########
dev/docker/Dockerfile.centos8-static-build:
##########
@@ -46,7 +46,7 @@ RUN set -ex; \
cd /opt/gluten; \
export SSL_VERIFY=false; \
bash ./dev/builddeps-veloxbe.sh --enable_vcpkg=ON --build_tests=ON
--enable_s3=ON --enable_gcs=ON \
- --enable_hdfs=ON --enable_abfs=ON
build_arrow; \
+ --enable_hdfs=ON --enable_abfs=ON true; \
Review Comment:
`dev/builddeps-veloxbe.sh` treats any trailing positional argument as an
explicit command to run. With `true` here, the script won't run its default
get/build steps, so this Dockerfile will skip building native dependencies.
Remove the `true` argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
