baibaichen commented on code in PR #12625:
URL: https://github.com/apache/gluten/pull/12625#discussion_r3650362582
##########
dev/vcpkg/ports/arrow/usage-parquet:
##########
@@ -0,0 +1,3 @@
+
+ find_package(Parquet CONFIG REQUIRED)
+ target_link_libraries(main PRIVATE
"$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,Parquet::parquet_static,Parquet::parquet_shared>")
Review Comment:
Leaving this unchanged in this PR. This feature usage snippet is copied
unchanged from the upstream vcpkg Arrow port and is only install-time guidance;
it is not consumed by Gluten or enabled by Gluten’s Arrow dependency. A generic
static/shared guidance change should be made upstream rather than diverging
this overlay.
##########
dev/vcpkg/ports/arrow/usage-dataset:
##########
@@ -0,0 +1,3 @@
+
+ find_package(ArrowDataset CONFIG REQUIRED)
+ target_link_libraries(main PRIVATE
"$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,ArrowDataset::arrow_dataset_static,ArrowDataset::arrow_dataset_shared>")
Review Comment:
Leaving this unchanged in this PR. This feature usage snippet is copied
unchanged from the upstream vcpkg Arrow port and is only install-time guidance;
it is not consumed by Gluten or enabled by Gluten’s Arrow dependency. A generic
static/shared guidance change should be made upstream rather than diverging
this overlay.
##########
dev/vcpkg/ports/arrow/usage-flightsql:
##########
@@ -0,0 +1,3 @@
+
+ find_package(ArrowFlightSql CONFIG REQUIRED)
+ target_link_libraries(main PRIVATE
"$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,ArrowFlightSql::arrow_flight_sql_static,ArrowFlightSql::arrow_flight_sql_shared>")
Review Comment:
Leaving this unchanged in this PR. This feature usage snippet is copied
unchanged from the upstream vcpkg Arrow port and is only install-time guidance;
it is not consumed by Gluten or enabled by Gluten’s Arrow dependency. A generic
static/shared guidance change should be made upstream rather than diverging
this overlay.
##########
dev/vcpkg/ports/arrow/usage-flight:
##########
@@ -0,0 +1,3 @@
+
+ find_package(ArrowFlight CONFIG REQUIRED)
+ target_link_libraries(main PRIVATE
"$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,ArrowFlight::arrow_flight_static,ArrowFlight::arrow_flight_shared>")
Review Comment:
Leaving this unchanged in this PR. This feature usage snippet is copied
unchanged from the upstream vcpkg Arrow port and is only install-time guidance;
it is not consumed by Gluten or enabled by Gluten’s Arrow dependency. A generic
static/shared guidance change should be made upstream rather than diverging
this overlay.
##########
dev/vcpkg/ports/arrow/usage:
##########
@@ -0,0 +1,4 @@
+The package arrow provides CMake targets:
+
+ find_package(Arrow CONFIG REQUIRED)
+ target_link_libraries(main PRIVATE
"$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,Arrow::arrow_static,Arrow::arrow_shared>")
Review Comment:
Leaving this unchanged in this PR. The usage snippet is copied unchanged
from the upstream vcpkg Arrow port and is only displayed as install-time
guidance; Gluten does not consume it and selects the exported static target in
`cpp/CMake/ConfigArrow.cmake`. Adjusting the generic upstream usage guidance is
outside this integration change.
##########
dev/vcpkg/ports/arrow/usage-acero:
##########
@@ -0,0 +1,3 @@
+
+ find_package(ArrowAcero CONFIG REQUIRED)
+ target_link_libraries(main PRIVATE
"$<IF:$<BOOL:${ARROW_BUILD_STATIC}>,ArrowAcero::arrow_acero_static,ArrowAcero::arrow_acero_shared>")
Review Comment:
Leaving this unchanged in this PR. This feature usage snippet is copied
unchanged from the upstream vcpkg Arrow port and is only install-time guidance;
it is not consumed by Gluten or enabled by Gluten’s Arrow dependency. A generic
static/shared guidance change should be made upstream rather than diverging
this overlay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
