brijrajk commented on PR #12151: URL: https://github.com/apache/gluten/pull/12151#issuecomment-5094523849
@zhztheplayer @philo-he Now that #12614 (the capacity fix) is merged, I've rebased this branch on top and added the `injectFinal` registration you proposed. Changes: - Rebased onto main (includes GLUTEN-12613 capacity fix) - Registered the existing `RuntimeBloomFilterRewriteRule` at `injectFinal` in addition to `injectPreTransform`, so it re-applies after `ExpandFallbackPolicy` reverts a stage - Added a regression test that reproduces the reversion gap directly: it fails with the expected version-mismatch crash if the `injectFinal` registration is removed, and passes with it in place - No changes to the rule itself, no consolidation with the logical rule Testing done locally: - `GlutenBloomFilterFallbackSuite`: 8/8 (new test included) - `GlutenBloomFilterAggregateQuerySuite`: 28/30 (2 failures are pre-existing and unrelated, confirmed identical on a clean baseline with these changes removed) - `GlutenInjectRuntimeFilterSuite`: 13/13 - Full TPC-DS/TPC-H plan-stability set: 322/322 This should be ready for another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
