zhztheplayer commented on PR #12151: URL: https://github.com/apache/gluten/pull/12151#issuecomment-5103532662
@brijrajk The bottom line is, we just ensure all Spark `bloomfilter_agg` and `might_contain` are replaced with `velox_bloomfilter_agg` (both partial and final) and `velox_might_contain`, with no regard to the operator-wise fallbacks. A vanilla (fallenback) subquery including `velox_bloomfilter_agg` should be compatible with an offloaded scan including `velox_might_contain`, and wise versa. Anything beyond that in the rules may over-complicate the approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
