Smallfu666 opened a new pull request, #12771:
URL: https://github.com/apache/gluten/pull/12771
## What
Re-enables the `SPARK-36286: invalid string cast to timestamp` test that was
disabled across all Spark version shims (spark33/34/35/40/41).
The test was disabled because Velox accepted `CAST('2015-03-18T' AS
TIMESTAMP)` as a valid date with zeroed time (`2015-03-18 00:00:00`), while
Spark returns `NULL` (a `T` separator must be followed immediately by the time
component).
Velox PR https://github.com/facebookincubator/velox/pull/18502 fixes the
parser to reject trailing-T strings. This PR re-enables the Gluten regression
test to validate that fix.
## Change
- Remove `.exclude("SPARK-36286: invalid string cast to timestamp")` from
`VeloxTestSettings.scala` in all 5 shims.
- Set `UPSTREAM_VELOX_PR_ID="18502"` in `ep/build-velox/src/get-velox.sh` so
Gluten CI builds its pinned Velox baseline with the proposed fix applied.
## Testing
`UPSTREAM_VELOX_PR_ID="18502"` is intentionally set so that Gluten CI:
1. checks out its normal pinned Velox baseline;
2. downloads Velox PR #18502 as a patch;
3. applies the patch;
4. builds Gluten/Velox;
5. runs the re-enabled SPARK-36286 test against the actual proposed Velox
fix.
Once #18502 is merged and Gluten's pinned Velox baseline contains the fix,
the PR ID pin can be removed.
## Related
- Velox PR: https://github.com/facebookincubator/velox/pull/18502
- Gluten issue: https://github.com/apache/gluten/issues/8984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
