Copilot commented on code in PR #12771: URL: https://github.com/apache/gluten/pull/12771#discussion_r3782149102
########## ep/build-velox/src/get-velox.sh: ########## @@ -25,7 +25,7 @@ RUN_SETUP_SCRIPT=ON ENABLE_ENHANCED_FEATURES=OFF # Developer use only for testing Velox PR. -UPSTREAM_VELOX_PR_ID="" +UPSTREAM_VELOX_PR_ID="18502" Review Comment: Hardcoding `UPSTREAM_VELOX_PR_ID` in the repo makes every `get-velox.sh` run download and apply an external PR patch, which can break offline builds and makes builds non-reproducible once the PR is rebased/closed/garbage-collected. Since the script comment says this is for developer testing, keep the default empty and let CI/users opt in via an environment variable (or a script flag). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
