felipepessoto commented on PR #12781: URL: https://github.com/apache/gluten/pull/12781#issuecomment-5300412737
Thanks — surfacing the two suppressed comments from [that review](https://github.com/apache/gluten/pull/12781#pullrequestreview-4942479836), since they aren't visible in the diff: **1. `delta_spark_ut.yml:220` — the acknowledgement step can block an authorised run.** Real bug, fixed in 625a3d7. The whole pipeline hangs off `delta-test-requested` via `needs`, so a transient `gh pr comment` failure (API blip, rate limit) would fail the gate job and skip every downstream job — silently dropping a run the contributor legitimately asked for, with no obvious cause. The comment is informational only, so the step is now `continue-on-error: true`: ```yaml - name: Acknowledge the request if: ${{ github.event_name == 'issue_comment' }} continue-on-error: true ``` **2. `delta_spark_ut.yml:186` — PR description out of sync with the gate.** Already resolved; the review snapshot just predates the edit. The description was updated alongside 625a3d7's predecessor d36c9dc and now reads "The gate is the **PR author only**", with the verification section listing "a non-author (including a maintainer) … rejected". No remaining claim of write-access-based triggering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
