felipepessoto commented on PR #12781: URL: https://github.com/apache/gluten/pull/12781#issuecomment-5349855468
Addressing the 2 suppressed comments from [review 4978060920](https://github.com/apache/gluten/pull/12781#pullrequestreview-4978060920): 1. **`pull-requests: write` may not permit `gh pr comment` — no change needed; the premise is false.** GitHub's [Create an issue comment](https://docs.github.com/en/rest/issues/comments#create-an-issue-comment) endpoint accepts either **Issues: write OR Pull requests: write**. More importantly, the [pre-merge e2e run](https://github.com/apache/gluten/pull/12781#issuecomment-5347525074) already exercised this exact step with the current job permissions: `github-actions` successfully posted the acknowledgement and run link using only `pull-requests: write`. There was no 403. Keeping the narrower PR-specific permission is preferable to adding general issue-write access. `continue-on-error` remains intentional for genuine transient failures (API outage/rate limiting): the informational comment must not block an authorized ~11 job-hour run. It is not masking a missing permission, as the e2e result proves. 2. **Grammar — valid, fixed in `b0ad8e7`.** Changed “cannot opt their own PR in” to “cannot opt into their own PR” in both the workflow comment and README. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
