LuciferYang opened a new pull request, #12889:
URL: https://github.com/apache/gluten/pull/12889
`ClickHouseTestSettings` in `gluten-ut/spark35` excludes three cases from
`GlutenTryCastSuite` with no comment:
```scala
.excludeCH("cast from array II")
.excludeCH("cast from array III")
.excludeCH("cast from struct III")
```
The same three run on `gluten-ut/spark33`: its `GlutenTryCastSuite` block
does not exclude them. All three are declared in Spark 3.3.1's
`AnsiCastSuiteBase`, which is the version the `spark-3.3` profile pins, so this
is a real difference between the two ClickHouse modules rather than a case that
postdates 3.3.
`backends-clickhouse/pom.xml` has only `spark-3.3` and `spark-3.5` profiles.
So when `gluten-ut/spark33` is removed under #12807 these three lose the only
place they run on ClickHouse. Removing the exclusions is the way to find out
whether that matters.
Draft, because I cannot answer this locally: there is no ClickHouse build on
my machine, and the ClickHouse CI is not in this repository. If the three fail,
the right outcome is to restore the exclusions with the reason written next to
them, which is what should have happened when they were added.
Only `gluten-ut/spark35` is touched. The same entries exist under
`gluten-ut/spark34`, `spark40` and `spark41`, but no ClickHouse profile selects
those modules, so changing them would not run anything.
Found while auditing which vanilla cases run on `gluten-ut/spark33` but on
none of the surviving versions. Tracked in #12863.
## Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude claude-opus-5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
