Copilot commented on code in PR #12889:
URL: https://github.com/apache/gluten/pull/12889#discussion_r3852317787
##########
gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/clickhouse/ClickHouseTestSettings.scala:
##########
@@ -1180,6 +1180,8 @@ class ClickHouseTestSettings extends BackendTestSettings {
enableSuite[GlutenMathExpressionsSuite]
// Spark round UT for round(3.1415,3) is not correct.
.exclude("round/bround/floor/ceil")
+ // ClickHouse's tanh differs from Spark's at the sixth significant digit:
+ // TANH(-0.1) returns -0.0996695958408681, the case expects
-0.09966799462495582.
Review Comment:
The comment says the result differs at the "sixth significant digit", but
the two values actually diverge at the 6th decimal place (the 5th significant
digit, since the leading 0 after the decimal isn’t significant). Suggest
rewording to avoid an inaccurate numeric claim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
