LuciferYang opened a new issue, #12891:
URL: https://github.com/apache/gluten/issues/12891

   ### What
   
   Six ClickHouse suites are enabled on `gluten-ut/spark33` and on no surviving 
version module:
   
   `GlutenInnerJoinSuite`, `GlutenOuterJoinSuite`, `GlutenJsonSuite`, 
`GlutenOrcQuerySuite`, `GlutenPercentileSuite`, `QueryTestSuite`
   
   `backends-clickhouse/pom.xml` has only `spark-3.3` and `spark-3.5` profiles, 
so ClickHouse coverage exists on exactly those two modules. When 
`gluten-ut/spark33` is removed under #12807, whatever these six cover on 
ClickHouse stops running anywhere.
   
   ### Two of the six are less clear-cut than the list suggests
   
   `GlutenInnerJoinSuite` and `GlutenOuterJoinSuite` have renamed variants on 
spark35, `GlutenInnerJoinSuiteForceShjOn` and `...ForceShjOff`, so the coverage 
may already be there under a different name. `QueryTestSuite` comes from 
Spark's own test jar rather than from a module file. That leaves 
`GlutenJsonSuite`, `GlutenOrcQuerySuite` and `GlutenPercentileSuite` as the 
ones most likely to be a genuine hole.
   
   ### Why this is a separate issue
   
   Whether to enable them on the ClickHouse 3.5 module is a 
ClickHouse-maintainer call, not part of removing Spark 3.3 support: enabling a 
suite that was never run there is likely to surface real failures that need 
real fixes. #12863 settled the vanilla-case axis and did not cover this. Filing 
it so the decision is recorded rather than made silently by a deletion.
   
   Related: #12807, #12863, #12889.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to