LuciferYang opened a new pull request, #12906: URL: https://github.com/apache/gluten/pull/12906
## What changes are proposed in this pull request? `delta_spark_ut.yml` triggers on `issue_comment: types: [created]`, which fires for every comment on every PR. For such an event `github.event.issue.number` resolves to the PR number, so the comment run lands in the same concurrency group as that PR's in-flight `pull_request` run, and `cancel-in-progress: true` kills it. The comment run then does not replace it: `delta-test-requested` skips anything that is not a `/delta-test` command, so the suite is simply gone. This is not hypothetical. On #12902 I posted an unrelated review comment at 03:37:39Z. It started `issue_comment` run 33036933287 at 03:37:43Z, which cancelled `pull_request` run 33034774777 forty-three minutes into the tests. From shard 7's log: ``` 2026-08-27T03:37:41.4970618Z [info] - merge-metrics: insert-only - Partitioned = true, CDF = false 2026-08-27T03:37:43.9917792Z context canceled 2026-08-27T03:37:44.0351639Z ##[error]The operation was canceled. ``` All eight shards and the aggregate job died within thirty seconds of each other, and the run that killed them concluded `skipped`. The signal lost was a real one: every failing test in that shard up to the cancellation was already listed in `known-failures.txt`, so nothing had regressed and the shard was on course to pass. The fix keeps the group as it is and makes the cancellation conditional, so only a real command cancels. The condition is `delta-test-requested`'s `if` repeated verbatim; normalizing whitespace makes the two strings compare equal, which is the property to check when reviewing this. Unchanged: a new push still cancels the older `pull_request` run for the same PR, and a real `/delta-test` still cancels an older run for that PR, which is what the comment above the block describes. ## How was this patch tested? The behavior cannot be exercised from this PR. `issue_comment` runs use the workflow file from the default branch, so a comment posted here will run main's copy no matter what this branch says; that is also why the run that cancelled #12902's suite used the unfixed version. It takes effect once merged. What I did check locally: - The file parses, and `concurrency.cancel-in-progress` reads back as the expected expression string. - That expression and `jobs.delta-test-requested.if` are character-identical after collapsing whitespace, verified by parsing both out of the YAML and comparing. The `if` is exercised on every comment today, so the expression form is already known to evaluate. ## Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude claude-opus-5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
