Copilot commented on code in PR #12906: URL: https://github.com/apache/gluten/pull/12906#discussion_r3877911980
########## .github/workflows/util/delta-spark-ut/known-failures.txt: ########## @@ -66,11 +66,6 @@ org.apache.spark.sql.delta.ConvertToDeltaScalaSuite#external tables use correct org.apache.spark.sql.delta.DeleteMetricsSuite#delete-metrics: delete one row per file - Partitioned = false, cdfEnabled = false org.apache.spark.sql.delta.DeleteMetricsSuite#delete-metrics: delete one row per file - Partitioned = false, cdfEnabled = true org.apache.spark.sql.delta.DeltaAllFilesInCrcSuite#test all-files-in-crc verification failure also triggers and logs incremental-commit verification result Review Comment: This PR is scoped/described as a CI concurrency fix, but this file also removes a number of entries from the Delta Spark UT known-failures baseline. That changes what the workflow will treat as an expected failure vs. a regression (and may start failing CI if those tests are still failing). If this baseline refresh is intentional, please document the rationale in the PR description and consider splitting it into a separate PR; otherwise, revert these baseline deletions to keep this change focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
