jackylee-ch commented on code in PR #12056:
URL: https://github.com/apache/gluten/pull/12056#discussion_r3889036234
##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetIOSuite.scala:
##########
@@ -17,14 +17,51 @@
package org.apache.spark.sql.execution.datasources.parquet
import org.apache.spark.sql._
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.types.{IntegerType, StringType, StructType}
/** A test suite that tests basic Parquet I/O. */
class GlutenParquetIOSuite extends ParquetIOSuite with GlutenSQLTestsBaseTrait
{
+ override def testNameBlackList: Seq[String] =
Review Comment:
`excludeByPrefix` does not match the `Gluten - ` prefix added by
`testGluten`; consequently, the `.excludeByPrefix("SPARK-54220")` setting in
`VeloxTestSettings` effectively allows your variant to keep running—a point
@philo-he raised back in May.
More importantly, the `testNameBlackList` mechanism is difficult to track:
it takes precedence over all backend-specific settings, meaning no backend can
re-enable the test, and the skipped tests won't be reflected in #11550—easily
leading to genuine issues being obscured within the test suite files.
It would be more appropriate to consolidate skip configurations applicable
to all backends into `GlutenTestSettings`; I will file an issue to see if we
can improve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
