wecharyu commented on code in PR #12056:
URL: https://github.com/apache/gluten/pull/12056#discussion_r3902229169


##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetIOSuite.scala:
##########
@@ -17,14 +17,51 @@
 package org.apache.spark.sql.execution.datasources.parquet
 
 import org.apache.spark.sql._
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.types.{IntegerType, StringType, StructType}
 
 /** A test suite that tests basic Parquet I/O. */
 class GlutenParquetIOSuite extends ParquetIOSuite with GlutenSQLTestsBaseTrait 
{
+  override def testNameBlackList: Seq[String] =

Review Comment:
   If exclude it in `VeloxTestSettings.scala`, we will also need exclude it in 
`ClickHouseTestSettings.scala` once the clickhouse ci enables gluten-ut for 
Spark 4.1,   because the original Spark test is not compatible with gluten as 
discussed in https://github.com/apache/gluten/pull/12056#discussion_r3252527294.
   
   If the duplicated excludes in both backends are acceptable, I'm happy to 
change this exclude to `VeloxTestSettings.scala`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to